yahoo-eng-team team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

is there a reason that you wouldn't have the right path set up?
My general feeling is that hard coded full paths defeat the purpose of $PATH with exactly *no* benefit and added knowledge that is possibly wrong.

Ie, if we use '/sbin/blkid', then if blkid is in$PATH but *not* in
/sbin, then i've just broken something that otherwise would have worked
fine.  it also makes mock tests *more* difficult.


** Changed in: cloud-init
       Status: New => Won't Fix

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1275415

Title:
  Absolute path to blkid.

Status in Init scripts for use on cloud images:
  Won't Fix

Bug description:
  Dear Scott and everybody,

  in Debian, we needed to provide the absolute path to blkid as follows
  in order to run the regression tests.

  Description: Fix the path to blkid in test suite
  Author: Thomas Goirand <zigo@xxxxxxxxxx>
  Last-Update: 2013-05-28

  --- cloud-init-0.7.2.orig/cloudinit/util.py
  +++ cloud-init-0.7.2/cloudinit/util.py
  @@ -998,7 +998,7 @@ def find_devs_with(criteria=None, oforma
         LABEL=<label>
         UUID=<uuid>
       """
  -    blk_id_cmd = ['blkid']
  +    blk_id_cmd = ['/sbin/blkid']
       options = []
       if criteria:
           # Search for block devices with tokens named NAME that

  Could you consider applying it ?

  Cheers,

  -- 
  Charles Plessy
  Tsurumi, Kanagawa, Japan
  Uploaded of cloud-init in Debian.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1275415/+subscriptions