← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1291174] Re: Calling patch.stop not needed in individual test cases

 

Even though addCleanup(mock.patch.stopall) is in the base test class, I
find that removing some of the existing individual stops causes test
failures during tox full suite runs. Abandoning this change since major
refactoring of neutron unit tests is planned.

** Changed in: neutron
       Status: In Progress => New

** Changed in: neutron
       Status: New => Invalid

** Changed in: neutron
     Assignee: Henry Gessau (gessau) => (unassigned)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1291174

Title:
  Calling patch.stop not needed in individual test cases

Status in OpenStack Neutron (virtual network service):
  Invalid

Bug description:
  https://bugs.launchpad.net/neutron/+bug/1290550 adds mock.patch.stopall to BaseTestCase.
  https://bugs.launchpad.net/neutron/+bug/1291130 removes stopall from individual test cases.

  We can now go one step further, and remove individual patch stops from
  cleanups.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1291174/+subscriptions


References