yahoo-eng-team team mailing list archive

Thread
Date
[Bug 1280021] Re: remove unneed calls to trigger_instance_add/remove_security_group

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Alan Pevec <1280021@xxxxxxxxxxxxxxxxxx>
Date: Fri, 21 Mar 2014 10:58:36 -0000
Reply-to: Bug 1280021 <1280021@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx
>From Gerrit review: "we don't need to merge this but I just put this
patch up incase anyone runs into this issue and wants this patch...."

** Also affects: nova/grizzly
   Importance: Undecided
       Status: New

** Changed in: nova/grizzly
       Status: New => Won't Fix

** Changed in: nova/grizzly
     Assignee: (unassigned) => Aaron Rosen (arosen)

** Changed in: nova
       Status: New => Invalid

** Changed in: nova
     Assignee: Aaron Rosen (arosen) => (unassigned)

** Tags removed: grizzly-backport-potential

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1280021

Title:
  remove unneed calls to trigger_instance_add/remove_security_group

Status in OpenStack Compute (Nova):
  Invalid
Status in OpenStack Compute (nova) grizzly series:
  Won't Fix

Bug description:
  If using quantum security groups in grizzly there is no need for the
  code to call
  trigger_instance_remove_security_group_refresh/trigger_instance_add_security_group_refresh
  as quantum handles all the security groups.   Calling these methods
  somethings causes the conductor to timeout in large deployments.

  
  2014-02-13 12:42:47.810 ERROR nova.api.openstack [req-15757329-26dd-4adc-9c55-ae619edd5a58 4daf45df65014b9f922c4e946c0c4e64 579070a0e01e4816a6fb7926b2d74256] Caught error: Timeout while waiting on RPC response.
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack Traceback (most recent call last):
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/api/openstack/__init__.py", line 81, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return req.get_response(self.application)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/request.py", line 1296, in send
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     application, catch_exc_info=False)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/request.py", line 1260, in call_application
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     app_iter = application(self.environ, start_response)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return resp(environ, start_response)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/keystoneclient/middleware/auth_token.py", line 450, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return self.app(env, start_response)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return resp(environ, start_response)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return resp(environ, start_response)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return resp(environ, start_response)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/routes/middleware.py", line 131, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     response = self.app(environ, start_response)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return resp(environ, start_response)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 130, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     resp = self.call_func(req, *args, **self.kwargs)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 195, in call_func
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return self.func(req, *args, **kwargs)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/api/openstack/wsgi.py", line 890, in __call__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     content_type, body, accept)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/api/openstack/wsgi.py", line 942, in _process_stack
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     action_result = self.dispatch(meth, request, action_args)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/api/openstack/wsgi.py", line 1022, in dispatch
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return method(req=request, **action_args)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/api/openstack/compute/servers.py", line 1117, in delete
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self._delete(req.environ['nova.context'], req, id)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/api/openstack/compute/servers.py", line 961, in _delete
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self.compute_api.delete(context, instance)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 163, in wrapped
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return func(self, context, target, *args, **kwargs)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 153, in inner
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return function(self, context, instance, *args, **kwargs)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 134, in inner
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return f(self, context, instance, *args, **kw)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 1233, in delete
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self._delete_instance(context, instance)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 1225, in _delete_instance
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     task_state=task_states.DELETING)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 1122, in _delete
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     project_id=project_id)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self.gen.next()
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 1105, in _delete
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self._local_delete(context, instance, bdms)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/compute/api.py", line 1173, in _local_delete
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     instance)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/network/quantumv2/api.py", line 327, in deallocate_for_instance
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self.trigger_security_group_members_refresh(context, instance)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/network/quantumv2/api.py", line 515, in trigger_security_group_members_refresh
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     admin_context, group_ids)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/conductor/api.py", line 659, in security_groups_trigger_members_refresh
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     context, group_ids)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/conductor/rpcapi.py", line 408, in security_groups_trigger_members_refresh
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return self.call(context, msg, version='1.40')
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/proxy.py", line 80, in call
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return rpc.call(context, self._get_topic(topic), msg, timeout)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/__init__.py", line 140, in call
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     return _get_impl().call(CONF, context, topic, msg, timeout)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/impl_kombu.py", line 798, in call
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     rpc_amqp.get_connection_pool(conf, Connection))
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/amqp.py", line 612, in call
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     rv = list(rv)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/amqp.py", line 554, in __iter__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self.done()
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self.gen.next()
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/amqp.py", line 551, in __iter__
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     self._iterator.next()
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/impl_kombu.py", line 648, in iterconsume
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     yield self.ensure(_error_callback, _consume)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/impl_kombu.py", line 566, in ensure
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     error_callback(e)
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack   File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/impl_kombu.py", line 629, in _error_callback
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack     raise rpc_common.Timeout()
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack Timeout: Timeout while waiting on RPC response.
  2014-02-13 12:42:47.810 30269 TRACE nova.api.openstack

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1280021/+subscriptions
References

[Bug 1280021] [NEW] remove unneed calls to trigger_instance_add/remove_security_group
From: Aaron Rosen, 2014-02-13