yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1291548

Title:
  verbose_name is unnecessary for hidden field

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  verbose_name is unnecessary for hidden field.
  Some verbose_name does not have much meaning (it is just a mirror of form field name) but it is marked as translated and such strings are difficult to translate. One I encountered is in openstack_dashboard/dashboards/project/containers/tables.py.

      metadata_loaded = tables.Column(get_metadata_loaded,
                                      verbose_name=_("Metadata Loaded"),
                                      status=True,
                                      status_choices=METADATA_LOADED_CHOICES,
                                      hidden=True)

  metadata_loaded is difficult to translate and there is no need to
  translate it too because it is invisible in a browser.

  I would suggest to delete verbose_name from hidden field.
  According to my check, we have only four hidden fields with verbose_name.
  it can be easy to clean up.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1291548/+subscriptions