← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1254488] Re: No need to mark lang name in LANGUAGES in settings.py translatable

 

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1254488

Title:
  No need to mark lang name in LANGUAGES in settings.py translatable

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Language names in LANGUAGES list in openstack_dashboard/settings.py
  are marked as translatable, but there is no need to mark them as
  translatable.

  https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L176

  - Language names displayed in the user settings panel  are actually extracted from django.conf.locale.__init__ and these strings are not referred (as long as languages are defined in django).
  - Even when a language is not defined in django, there is no need the language is displayed as translated string because a user of some language cannot understand the translated string if another language is displayed in the lang menu.

  I would like to suggest to remove "gettext_noop".

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1254488/+subscriptions