yahoo-eng-team team mailing list archive

Thread
Date
[Bug 1294069] Re: XenAPI: Boot from volume without image_ref broken

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Mon, 31 Mar 2014 19:05:43 -0000
Reply-to: Bug 1294069 <1294069@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx
** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1294069

Title:
  XenAPI: Boot from volume without image_ref broken

Status in devstack - openstack dev environments:
  Fix Released
Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  https://review.openstack.org/#/c/78194/ changed tempest to clear
  image_ref for some BFV tests - in particular the
  test_volume_boot_pattern

  This now results in a "KeyError: 'disk_format'" exception from Nova
  when using the XenAPI driver.

  http://paste.openstack.org/show/73733/ is a nicer format of the below
  - but might disappear!

  2014-03-18 11:20:07.475 ERROR nova.compute.manager [req-82096fe0-921a-4bc1-9c41-d0aafad4c923 TestVolumeBootPattern-581093620 TestVolumeBootPattern-1800543246] [instance: 2b047f24-675c-4921-8cf3-85584097f106] Error: 'disk_format'
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106] Traceback (most recent call last):
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/compute/manager.py", line 1306, in _build_instance
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     set_access_ip=set_access_ip)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/compute/manager.py", line 394, in decorated_function
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     return function(self, context, *args, **kwargs)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/compute/manager.py", line 1708, in _spawn
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     LOG.exception(_('Instance failed to spawn'), instance=instance)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/openstack/common/excutils.py", line 68, in __exit__
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     six.reraise(self.type_, self.value, self.tb)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/compute/manager.py", line 1705, in _spawn
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     block_device_info)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 236, in spawn
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     admin_password, network_info, block_device_info)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 357, in spawn
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     network_info, block_device_info, name_label, rescue)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 526, in _spawn
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     undo_mgr.rollback_and_reraise(msg=msg, instance=instance)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/utils.py", line 812, in rollback_and_reraise
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     self._rollback()
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/openstack/common/excutils.py", line 68, in __exit__
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     six.reraise(self.type_, self.value, self.tb)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 501, in _spawn
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     disk_image_type = determine_disk_image_type_step(undo_mgr)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 146, in inner
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     rv = f(*args, **kwargs)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 414, in determine_disk_image_type_step
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     return vm_utils.determine_disk_image_type(image_meta)
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]   File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1647, in determine_disk_image_type
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]     disk_format = image_meta['disk_format']
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106] KeyError: 'disk_format'
  2014-03-18 11:20:07.475 TRACE nova.compute.manager [instance: 2b047f24-675c-4921-8cf3-85584097f106]

  I've confirmed that running without
  https://review.openstack.org/#/c/78194/ passes the tests (although
  there is a race condition, which is why test_volume_boot_pattern is
  disabled in the XenServer CI system) but will always fail with
  https://review.openstack.org/#/c/78194/ applied.

To manage notifications about this bug go to:
https://bugs.launchpad.net/devstack/+bug/1294069/+subscriptions
References

[Bug 1294069] [NEW] XenAPI: Boot from volume without image_ref broken
From: Bob Ball, 2014-03-18