yahoo-eng-team team mailing list archive

[OpenStack Infra <1302091@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/85507
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=354bc1ab4b1490b72abf80cfd2860337f1ccb369
Submitter: Jenkins
Branch:    milestone-proposed

commit 354bc1ab4b1490b72abf80cfd2860337f1ccb369
Author: sridhargaddam <sridhar.gaddam@xxxxxxxxxxxx>
Date:   Thu Apr 3 23:29:37 2014 +0530

    Redundant SG rule create calls in unit tests
    
    This patch removes the redundant calls in the test cases.
    
    Closes-Bug: #1302091
    Change-Id: I509843b427dc454c0e6b2fd2cbff1bbbb284337f
    (cherry picked from commit c49ec8b3ba10bb414a0f135d29ff3685e26d58b3)


** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1302091

Title:
  Redundant SG rule create calls in unit tests

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  The following test cases in TestSecurityGroups of test_extension_security_group.py file 
  are making multiple calls to create a SG rule.
  test_create_security_group_rule_min_port_greater_max()
  test_create_security_group_rule_ports_but_no_protocol()
  test_create_security_group_rule_port_range_min_only()
  test_create_security_group_rule_port_range_max_only()
  test_create_security_group_rule_icmp_type_too_big()
  test_create_security_group_rule_icmp_code_too_big()

  The redundant calls can be removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1302091/+subscriptions