yahoo-eng-team team mailing list archive

[OpenStack Infra <1297875@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/85503
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5417220fc50fb31218ed1ed2aba6b926591c5f81
Submitter: Jenkins
Branch:    milestone-proposed

commit 5417220fc50fb31218ed1ed2aba6b926591c5f81
Author: Miguel Angel Ajo <mangelajo@xxxxxxxxxx>
Date:   Tue Mar 18 13:33:19 2014 +0100

    fixes broken neutron-netns-cleanup
    
    Some configuration parameters used in neutron.agent.linux.utils
    were missing. The namespace attribute in the FakeNetwork object
    was missing, and used in neutron.agent.linux.dhcp. Also, the
    plugin object was missing for release_dhcp_port operation.
    
    We provide a fake plugin object to accept current and any future
    plugin calls as this is meant to be an standalone tool that
    should work without any RPC connectivity.
    
    FakeNetwork was switched for neutron.agent.linux.dhcp.NetModel
    to follow any future changes in NetModel.
    
    Two wrong called_once_with_args calls without assert were fixed.
    
    Change-Id: Ia51ea9bd4c8eea6b250858964ad5286c933702e0
    Closes-Bug: #1291915
    Partial-Bug: #1297875
    (cherry picked from commit 907bf41afbdb9f565c45a535f637c8928d0be52a)


** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1297875

Title:
  some tests call "called_once_with_args" with no assert, those lines
  are ignored

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  A few tests use "called_once_with_args"  instead of mock's "assert_called_once_with_args"
  without checking the result.

  That means that we're not asserting for that to happen.

  Those tests need to be fixed.

  
  [majopela@f20-devstack neutron]$ grep ".called_once_with" * -R | grep -v assert
  neutron/tests/unit/test_dhcp_agent.py:            disable.called_once_with_args(network.id)

  neutron/tests/unit/test_dhcp_agent.py:
  uuid5.called_once_with(uuid.NAMESPACE_DNS, 'localhost')

  neutron/tests/unit/test_post_mortem_debug.py:
  mock_print_exception.called_once_with(*exc_info)

  neutron/tests/unit/test_db_migration.py:
  mock_open.write.called_once_with('a')

  neutron/tests/unit/test_agent_netns_cleanup.py:
  ovs_br_cls.called_once_with('br-int', conf.AGENT.root_helper)

  neutron/tests/unit/test_metadata_agent.py:
  self.eventlet.wsgi.server.called_once_with(

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1297875/+subscriptions