← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1293508] Re: NSX plugin: 400 should be returned on invalid certificate

 

Reviewed:  https://review.openstack.org/85506
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d56f12d4676c1cc26d0da80e053da07e0253dbe8
Submitter: Jenkins
Branch:    milestone-proposed

commit d56f12d4676c1cc26d0da80e053da07e0253dbe8
Author: Salvatore Orlando <salv.orlando@xxxxxxxxx>
Date:   Fri Mar 14 17:43:42 2014 -0700

    NSX plugin: return 400 for invalid gw certificate
    
    Gateway certificates are validated by the NSX backend.
    The code currently treats a failure in certification
    validation as a backend failure and therefore returns
    a 500 status code.
    
    This patch changes this behaviour by returning a 400
    status code and an appropriate error description.
    To this aim a handler for 400 errors has been added to
    the NSX API client.
    
    Closes-Bug: #1293508
    
    Change-Id: I196f14337e47cd40710a6d8a30bbe1cac5ffe05b
    (cherry picked from commit 13c9f3b813f5bb368e311ba0d428fa759d68289a)


** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1293508

Title:
  NSX plugin: 400 should be returned on invalid certificate

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  When a gateway device is created, the client certificate is not stored
  anywhere on the neutron server, but then passed directly to the
  backend, which validates the certificate.

  Currently the NSX backend raises an exception when the certificate is not valid.
  This exception is treated by the NSX plugin as a backend failure and a 500 is then returned.

  However, the correct error would a 400 with an appropriate error
  message.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1293508/+subscriptions


References