← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1215387] Re: can not stop l3-agent router forwarding packets by admin_state_up false

 

Reviewed:  https://review.openstack.org/86017
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=472412a000d12659bf2eb324277f8ee7168aa0c8
Submitter: Jenkins
Branch:    milestone-proposed

commit 472412a000d12659bf2eb324277f8ee7168aa0c8
Author: Carl Baldwin <carl.baldwin@xxxxxx>
Date:   Tue Apr 1 22:02:17 2014 +0000

    Delete routers that are requested but not reported as active
    
    There are two cases that I can think of that result in a router being
    requested but not reported as active.  One is that admin_state_up has
    been set to False.  In this case, the router is never removed and
    continues to be operational.
    
    The other case is if a router is changed and then deleted before the
    change is processed.  In this case, it is prudent to be sure that the
    router is queued for deletion.
    
    Change-Id: I4738f599a18f0d130cc8ad4d4dafc488eec75ffd
    Closes-Bug: #1215387
    (cherry picked from commit 9da60d0a417dd70c16ae34f5877c564e425e4cf8)


** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1215387

Title:
  can not stop l3-agent router forwarding packets by admin_state_up
  false

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  We can not stop router forwarding packets by admin_state_up false.
  Master branch has this problem (stable/grizzly branch don't have the problem).
  I know the cause. When run router-update --admin_state_up false, transitions as follows:

  sync_routers(l3_rpc_base)→list_active_sync_routers_on_active_l3_agent(agent
  schedulers_db)→get_sync_data(l3_db)→_get_sync_routers(l3_db)

  list_active_sync_routers_on_active_l3_agent pass key 'active=True', and router that set admin_state_up false is ignored by filters['admin_state_up'] = [active] in _get_sync_routers.
  I think that active=True is not identical  admin_state_up True and that is more similar status Active.
  I will modify here.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1215387/+subscriptions