yahoo-eng-team team mailing list archive

Thread
Date
[Bug 1314269] [NEW] missing code after patch in nova/tests/virt/libvirt/test_imagebackend.py

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Hauke Bruno <1314269@xxxxxxxxxxxxxxxxxx>
Date: Tue, 29 Apr 2014 16:30:16 -0000
Reply-to: Bug 1314269 <1314269@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx
Public bug reported:

nova-compute.log on kvm:

2014-04-28 14:51:57.294 14659 ERROR nova.compute.manager [req-e9768eff-116d-4681-9ff6-3ab51dbbdee0 c460eaefef634e4bab938915224a6201 e159f0e56ea545bd84529fc38063
ceee] [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] Instance failed to spawn
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] Traceback (most recent call last):
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/compute/
manager.py", line 1423, in _spawn
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     block_device_info)
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
virt/driver.py", line 2088, in spawn
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     write_to_disk=True)
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
virt/driver.py", line 3084, in to_xml
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     disk_info, rescue, block_device_info)
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
virt/driver.py", line 2960, in get_guest_config
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     inst_type):
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
virt/driver.py", line 2737, in get_guest_storage_config
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     inst_type)
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
virt/driver.py", line 2700, in get_guest_disk_config
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     self.get_hypervisor_version())
2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] TypeError: libvirt_info() takes exactly 6 arguments (7
 given)

I found this bug https://bugs.launchpad.net/nova/+bug/1233188 and a
patch that should fix this issue
(https://review.openstack.org/#/c/72575/1//COMMIT_MSG).

But on Ubuntu 12.04.4 LTS with Openstack Havana installed from Ubuntu
Cloud Archive this issue is still available because one of the two
patched files from this commit isn't present. The changes from
https://review.openstack.org/#/c/72575/1/nova/tests/virt/libvirt/test_imagebackend.py
are missing. I manually added those lines in test_imagebackend.py and
Openstack is working fine.

My nova version:

ii  nova-common                      1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - common files
ii  nova-compute                     1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - compute node
ii  nova-compute-kvm                 1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - compute node (KVM)
ii  python-nova                      1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute Python libraries
ii  python-novaclient                1:2.15.0-0ubuntu1~cloud0                   client library for OpenStack Compute API

Let me know if you need further information, poorly I am not a developer
so my this report might seem a bit plain.

** Affects: nova
     Importance: Undecided
         Status: New

** Description changed:

  nova-compute.log on kvm:
  
  2014-04-28 14:51:57.294 14659 ERROR nova.compute.manager [req-e9768eff-116d-4681-9ff6-3ab51dbbdee0 c460eaefef634e4bab938915224a6201 e159f0e56ea545bd84529fc38063
  ceee] [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] Instance failed to spawn
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] Traceback (most recent call last):
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/compute/
  manager.py", line 1423, in _spawn
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     block_device_info)
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 2088, in spawn
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     write_to_disk=True)
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 3084, in to_xml
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     disk_info, rescue, block_device_info)
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 2960, in get_guest_config
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     inst_type):
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 2737, in get_guest_storage_config
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     inst_type)
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 2700, in get_guest_disk_config
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     self.get_hypervisor_version())
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] TypeError: libvirt_info() takes exactly 6 arguments (7
-  given)
+  given)
  
- 
- I found this bug https://bugs.launchpad.net/nova/+bug/1233188 and a patch that should fix this issue (https://review.openstack.org/#/c/72575/1//COMMIT_MSG).
+ I found this bug https://bugs.launchpad.net/nova/+bug/1233188 and a
+ patch that should fix this issue
+ (https://review.openstack.org/#/c/72575/1//COMMIT_MSG).
  
  But on Ubuntu 12.04.4 LTS with Openstack Havana installed from Ubuntu
- Cloud Archive this issue is still available because on of the two
+ Cloud Archive this issue is still available because one of the two
  patched files from this commit isn't present. The changes from
  https://review.openstack.org/#/c/72575/1/nova/tests/virt/libvirt/test_imagebackend.py
  are missing. I manually added those lines in test_imagebackend.py and
  Openstack is working fine.
  
  My nova version:
  
  ii  nova-common                      1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - common files
  ii  nova-compute                     1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - compute node
  ii  nova-compute-kvm                 1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - compute node (KVM)
  ii  python-nova                      1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute Python libraries
  ii  python-novaclient                1:2.15.0-0ubuntu1~cloud0                   client library for OpenStack Compute API
  
  Let me know if you need further information, poorly I am not a developer
  so my this report might seem a bit plain.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1314269

Title:
  missing code after patch in
  nova/tests/virt/libvirt/test_imagebackend.py

Status in OpenStack Compute (Nova):
  New

Bug description:
  nova-compute.log on kvm:

  2014-04-28 14:51:57.294 14659 ERROR nova.compute.manager [req-e9768eff-116d-4681-9ff6-3ab51dbbdee0 c460eaefef634e4bab938915224a6201 e159f0e56ea545bd84529fc38063
  ceee] [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] Instance failed to spawn
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] Traceback (most recent call last):
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/compute/
  manager.py", line 1423, in _spawn
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     block_device_info)
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 2088, in spawn
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     write_to_disk=True)
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 3084, in to_xml
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     disk_info, rescue, block_device_info)
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 2960, in get_guest_config
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     inst_type):
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 2737, in get_guest_storage_config
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     inst_type)
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]   File "/usr/lib/python2.7/dist-packages/nova/virt/lib
  virt/driver.py", line 2700, in get_guest_disk_config
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef]     self.get_hypervisor_version())
  2014-04-28 14:51:57.294 14659 TRACE nova.compute.manager [instance: 61a3e08f-b22f-47a8-a815-f586422860ef] TypeError: libvirt_info() takes exactly 6 arguments (7
   given)

  I found this bug https://bugs.launchpad.net/nova/+bug/1233188 and a
  patch that should fix this issue
  (https://review.openstack.org/#/c/72575/1//COMMIT_MSG).

  But on Ubuntu 12.04.4 LTS with Openstack Havana installed from Ubuntu
  Cloud Archive this issue is still available because one of the two
  patched files from this commit isn't present. The changes from
  https://review.openstack.org/#/c/72575/1/nova/tests/virt/libvirt/test_imagebackend.py
  are missing. I manually added those lines in test_imagebackend.py and
  Openstack is working fine.

  My nova version:

  ii  nova-common                      1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - common files
  ii  nova-compute                     1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - compute node
  ii  nova-compute-kvm                 1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute - compute node (KVM)
  ii  python-nova                      1:2013.2.2-0ubuntu1~cloud0                 OpenStack Compute Python libraries
  ii  python-novaclient                1:2.15.0-0ubuntu1~cloud0                   client library for OpenStack Compute API

  Let me know if you need further information, poorly I am not a
  developer so my this report might seem a bit plain.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1314269/+subscriptions
Follow ups

[Bug 1314269] Re: missing code after patch in nova/tests/virt/libvirt/test_imagebackend.py
From: Sean Dague, 2015-04-01
[Bug 1314269] [NEW] missing code after patch in nova/tests/virt/libvirt/test_imagebackend.py
From: Hauke Bruno, 2014-04-29
References

[Bug 1314269] [NEW] missing code after patch in nova/tests/virt/libvirt/test_imagebackend.py
From: Hauke Bruno, 2014-04-29