← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1315237] [NEW] Glance should not call configure and configure_add two times at startup

 

Public bug reported:

Currently at startup Glance is first creating the stores and then
verifying the default store (cmd/api.py)

 30         glance.store.create_stores()
 31         glance.store.verify_default_store()

In both of these calls, the store objects are created (store/base.py)
which means that if the methods configure() and configure_add() methods
are defined in the store, these methods will be called two times: 1 time
in the "create_stores()" phase and 1 time in the verify_default_store()
phase.

It turns out that the configure()/configure_add() method can contain
remote calls (which can potentially be expensive): in which case we do
not want them to happen two times. Having configure/configure_add called
only one time will speed up the Glance startup time for some of the
stores.

** Affects: glance
     Importance: Undecided
     Assignee: Arnaud Legendre (arnaudleg)
         Status: New

** Changed in: glance
     Assignee: (unassigned) => Arnaud Legendre (arnaudleg)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1315237

Title:
  Glance should not call configure and configure_add two times at
  startup

Status in OpenStack Image Registry and Delivery Service (Glance):
  New

Bug description:
  Currently at startup Glance is first creating the stores and then
  verifying the default store (cmd/api.py)

   30         glance.store.create_stores()
   31         glance.store.verify_default_store()

  In both of these calls, the store objects are created (store/base.py)
  which means that if the methods configure() and configure_add()
  methods are defined in the store, these methods will be called two
  times: 1 time in the "create_stores()" phase and 1 time in the
  verify_default_store() phase.

  It turns out that the configure()/configure_add() method can contain
  remote calls (which can potentially be expensive): in which case we do
  not want them to happen two times. Having configure/configure_add
  called only one time will speed up the Glance startup time for some of
  the stores.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1315237/+subscriptions


Follow ups

References