← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1307412] Re: The API v2 reserved property error is not raised when there's nothing to update

 

turns out the client is not sending the owner field update, which IMHO,
is wrong. These kind of optimizations belong to the server, not the
client. I'll move this bug to the client and update the title.

** Project changed: glance => python-glanceclient

** Summary changed:

- The API v2 reserved property error is not raised when there's nothing to update
+ The client should *always* send the full update request to the server

** Changed in: python-glanceclient
     Assignee: Flavio Percoco (flaper87) => (unassigned)

** Description changed:

- [root@orange-vdse ~(keystone_admin)]# glance --os-image-api-version 2 image-update 9969c805-c5e6-4d4b-b9e3-dd867a06be08 --owner 637ea20d137e4fa3bdbbb89ec513ef05Request returned failure status.
+ [root@orange-vdse ~(keystone_admin)]# glance --os-image-api-version 2 image-update fc4bfa83-6eea-4090-91a3-92b02668570d --owner 637ea20d137e4fa3bdbbb89ec513ef05Request returned failure status.
  403 Forbidden
  Attribute 'owner' is reserved.
-     (HTTP 403)
+     (HTTP 403)
  
  
- However, if the owner is updated using the API v1, then the same command mentioned above will succeed without error. This may be confusing for the user. Reserved words errors should be raised even for noops
+ However, if the owner remains unchanged, the client won't send it to the server:
+ 
+ [fedora@cinder devstack]$ glance --os-image-api-version 2 image-update fc4bfa83-6eea-4090-91a3-92b02668570d --owner cf7d037795cd45919e9d2824c72d0bae
+ +------------------+--------------------------------------+
+ | Property         | Value                                |
+ +------------------+--------------------------------------+
+ | checksum         | 51bc16b900bf0f814bb6c0c3dd8f0790     |
+ | container_format | bare                                 |
+ | created_at       | 2014-05-02T10:36:23Z                 |
+ | disk_format      | qcow2                                |
+ | id               | fc4bfa83-6eea-4090-91a3-92b02668570d |
+ | min_disk         | 0                                    |
+ | min_ram          | 0                                    |
+ | name             | Fedora-x86_64-20-20131211.1-sda      |
+ | owner            | cf7d037795cd45919e9d2824c72d0bae     |
+ | protected        | False                                |
+ | size             | 214106112                            |
+ | status           | active                               |
+ | tags             | []                                   |
+ | updated_at       | 2014-05-02T10:36:24Z                 |
+ | visibility       | public                               |
+ +------------------+--------------------------------------+

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1307412

Title:
  The client should *always* send the full update request to the server

Status in Python client library for Glance:
  New

Bug description:
  [root@orange-vdse ~(keystone_admin)]# glance --os-image-api-version 2 image-update fc4bfa83-6eea-4090-91a3-92b02668570d --owner 637ea20d137e4fa3bdbbb89ec513ef05Request returned failure status.
  403 Forbidden
  Attribute 'owner' is reserved.
      (HTTP 403)

  
  However, if the owner remains unchanged, the client won't send it to the server:

  [fedora@cinder devstack]$ glance --os-image-api-version 2 image-update fc4bfa83-6eea-4090-91a3-92b02668570d --owner cf7d037795cd45919e9d2824c72d0bae
  +------------------+--------------------------------------+
  | Property         | Value                                |
  +------------------+--------------------------------------+
  | checksum         | 51bc16b900bf0f814bb6c0c3dd8f0790     |
  | container_format | bare                                 |
  | created_at       | 2014-05-02T10:36:23Z                 |
  | disk_format      | qcow2                                |
  | id               | fc4bfa83-6eea-4090-91a3-92b02668570d |
  | min_disk         | 0                                    |
  | min_ram          | 0                                    |
  | name             | Fedora-x86_64-20-20131211.1-sda      |
  | owner            | cf7d037795cd45919e9d2824c72d0bae     |
  | protected        | False                                |
  | size             | 214106112                            |
  | status           | active                               |
  | tags             | []                                   |
  | updated_at       | 2014-05-02T10:36:24Z                 |
  | visibility       | public                               |
  +------------------+--------------------------------------+

To manage notifications about this bug go to:
https://bugs.launchpad.net/python-glanceclient/+bug/1307412/+subscriptions


References