← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1298769] Re: Nova API Sample file and its test for get keypair API is wrong

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => juno-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1298769

Title:
  Nova API Sample file and its test for get keypair API is wrong

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  Problem -
  API sample file for Nova get keypair API is wrong. It contain the response sample of list keypair API. 
  Below API sample files, from their name it looks like these are for get keypair API. But in actual content of these files are written as List keypair API response. So it create the confusion that for which API these API sample file are.  Name suggest for GET and content suggest for LIST Keypair.

          /nova/tests/integrated/api_samples/os-keypairs/keypairs-get-resp.json.tpl
          /nova/tests/integrated/api_samples/os-keypairs/keypairs-get-resp.xml.tpl

  Their API sample test cases are written corrosponding to list keypair
  APIs. This issue is in  both V2 and V3 APIs sample.

  Solution-
   - Here we need to rename the above sample files and their test from 'keypairs-get-resp.json.tpl' to 'keypairs-list-resp.json.tpl' etc
   - Create the new sample file and test for GET keypair.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1298769/+subscriptions


References