yahoo-eng-team team mailing list archive

[Russell Bryant <1318891@xxxxxxxxxxxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => juno-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1318891

Title:
  detach_pci_devices failed

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  when detach a pci device from instance

  the method  _detach_pci_devices will check if pci device detached

  >      for hdev in [d for d in guest_config.devices
  >                        if d.type == 'pci']:

  guest_config.devices will have more device not only pci, like disk

  in LibvirtConfigGuestDisk has no attribute type

    File "/home/xiaoding/nova/nova/tests/virt/libvirt/test_libvirt.py", line 684, in test_detach_pci_devices
      conn._detach_pci_devices(FakeDomain(), pci_devices)
    File "/home/xiaoding/nova/nova/virt/libvirt/driver.py", line 2774, in _detach_pci_devices
      if d.type == 'pci']:
  AttributeError: 'LibvirtConfigGuestDisk' object has no attribute 'type'


  https://review.openstack.org/#/c/93383/

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1318891/+subscriptions