← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1254705] Re: _rule_dict_last_step in ec2/cloud.py doesn't respect Security Group API

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => juno-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1254705

Title:
  _rule_dict_last_step in ec2/cloud.py doesn't respect Security Group
  API

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  Maybe this is a bug.

  I observed that the _rule_dict_last_step function in ec2/cloud.py
  always use the nova included database funktions to resolve
  securitygroup names , but doesn't call the given security api instance
  if security groups are resolved. The potential error is fixed by this
  patch -- which is maybe incomplete:

  --- api/ec2/cloud.py_old	2013-11-25 13:27:04.036359251 +0100
  +++ api/ec2/cloud.py	2013-11-25 13:27:51.308549582 +0100
  @@ -590,9 +590,8 @@
               source_project_id = self._get_source_project_id(context,
                   source_security_group_owner_id)
   
  -            source_security_group = db.security_group_get_by_name(
  +            source_security_group = self.security_group_api.get(
                       context.elevated(),
  -                    source_project_id,
                       source_security_group_name)
   
               notfound = exception.SecurityGroupNotFound

  Is this a problem in my installation? Or is there a logical problem?

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1254705/+subscriptions