yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1343604] Re: Exceptions thrown, and messages logged by execute() may include passwords

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Thu, 31 Jul 2014 09:19:51 -0000
Reply-to: Bug 1343604 <1343604@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Also affects: trove
   Importance: Undecided
       Status: New

** Also affects: cinder
   Importance: Undecided
       Status: New

** Also affects: nova
   Importance: Undecided
       Status: New

** Also affects: nova/icehouse
   Importance: Undecided
       Status: New

** Also affects: nova/havana
   Importance: Undecided
       Status: New

** Also affects: trove/havana
   Importance: Undecided
       Status: New

** Also affects: trove/icehouse
   Importance: Undecided
       Status: New

** Also affects: cinder/icehouse
   Importance: Undecided
       Status: New

** Also affects: cinder/havana
   Importance: Undecided
       Status: New

** Changed in: ossa
       Status: Confirmed => Triaged

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1343604

Title:
  Exceptions thrown, and messages logged by execute() may include
  passwords

Status in Cinder:
  New
Status in Cinder havana series:
  New
Status in Cinder icehouse series:
  New
Status in OpenStack Compute (Nova):
  New
Status in OpenStack Compute (nova) havana series:
  New
Status in OpenStack Compute (nova) icehouse series:
  New
Status in Oslo - a Library of Common OpenStack Code:
  In Progress
Status in OpenStack Security Advisories:
  Triaged
Status in Openstack Database (Trove):
  New
Status in Trove havana series:
  New
Status in Trove icehouse series:
  New

Bug description:
  Currently when execute() throws a ProcessExecutionError, it returns
  the command without masking passwords. In the one place where it logs
  the command, it correctly masks the password.

  It would be prudent to mask the password in the exception as well so
  that upstream catchers don't have to go through the mask_password()
  motions.

  The same also goes for stdout and stderr information which should be
  sanitized.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1343604/+subscriptions