yahoo-eng-team team mailing list archive

[Thai Tran <tqtran@xxxxxxxxxx>]

The more I think about this, the more I realize that this is more a
blueprint than a bug...

** Changed in: horizon
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1351438

Title:
  Code repetition in modal body and footer

Status in OpenStack Dashboard (Horizon):
  Invalid

Bug description:
  The modal code below is very common and we see it repeated in many
  templates.

  {% block modal-body %}
  <div class="left">
      <fieldset>
      {% include "horizon/common/_form_fields.html" %}
      </fieldset>
  </div>
  <div class="right">
      <h3>{% trans "Description:" %}</h3>
      <p>{% trans "Choose the rule you want to remove." %}</p>
  </div>
  {% endblock %}

  {% block modal-footer %}
    <input class="btn btn-primary pull-right" type="submit" value="{% trans "Some value" %}" />
    <a href="{% url 'url' %}" class="btn btn-default secondary cancel close">{% trans "Cancel" %}</a>
  {% endblock %}

  We need to provide a mechanism to replace these values in the base
  modal_form.html in python instead. That way, there is less template
  clutter. This would keep the code cleaner and would likely work better
  with serialization for angular in the future.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1351438/+subscriptions