yahoo-eng-team team mailing list archive

[Morgan Fainberg <morgan.fainberg@xxxxxxxxx>]

I did a bit more research, dogpile is handling this based upon the
[cache] expiration_time option.

https://github.com/openstack/keystone/blob/249d83529af0c746c6980aa0dbd2287bc8de345e/keystone/common/config.py#L293-L297

Which is set at the cache region level. If the decorator receives None as the expiration time.
https://bitbucket.org/zzzeek/dogpile.cache/src/1c753914b335b4391bc5847a87b7c52ca81c2bc6/dogpile/cache/region.py#cl-663
called via the decorator:
https://bitbucket.org/zzzeek/dogpile.cache/src/1c753914b335b4391bc5847a87b7c52ca81c2bc6/dogpile/cache/region.py#cl-960


** Changed in: keystone
       Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1355919

Title:
  By default when caching is enabled, objects will be cached forever

Status in OpenStack Identity (Keystone):
  Invalid

Bug description:
  The `cache_time` setting for the assignments, catalogs and tokens is
  currently set to None by default.  This means that if caching is
  enabled for one of those subsystems and the operator did not specify
  their own timeout the data will not automatically expire.

  We are doing invalidation when data changes, at least in some cases.
  I'm not sure that it's safe to say that anytime the data changes we
  are correctly invaliding the key.  We should strive to do this as it's
  the right thing to do, but we should also have a default timeout so
  that things we miss will not slip through.

  I believe 10 minutes is a reasonable default for most things so I'll
  provide a patch with that as the value.  When I read `cache_time` I
  see "the only acceptable amount of time to accept stale data".
  Usually this is determined base on the information being cached, but
  we currently only have the ability to set this at the subsystem level.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1355919/+subscriptions