← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1255144] Re: Deleted instances are resurrected by nova startup code

 

Reviewed: https://review.openstack.org/55660
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0252d0981af9daaf9370a50c28d8baf4a9d29619
Submitter: Jenkins
Branch: master

This was fixed by the following fix to
https://bugs.launchpad.net/nova/+bug/1247174


commit 0252d0981af9daaf9370a50c28d8baf4a9d29619
Author: Stanislaw Pitucha <stanislaw.pitucha@xxxxxx>
Date: Fri Nov 8 13:38:08 2013 +0000

    Cleanup 'deleting' instances on restart

    In case some instance was marked as deleting but for some reason didn't
    finish (for example request was stuck in libvirt), retry the delete at
    startup. This happens at startup and on the host owning the instance,
    so there's no reason to use the lock.

    Change-Id: Iad18e9a7c6cb8e272e67a82284127ad895441dcf
    Partial-Bug: #1248563
    Closes-Bug: 1247174
    Implements: blueprint recover-stuck-state


** Changed in: nova
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1255144

Title:
  Deleted instances are resurrected by nova startup code

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  When the nova manager starts it goes through code to initialise the
  host (init_host), including each instance (in _init_instance). The
  _init_instance code checks  the instance power state in the database;
  if it is power_state.RUNNING and the instance on the host is not
  power_state.RUNNING, it will start the instance. One side-effect of
  this is that instances that are in the task state "deleting" and are
  not there when the manager starts up will be recreated.

  This needs to be changed to stop deleted instances being recreated.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1255144/+subscriptions