← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1362733] Re: Rebuilding a node in ERROR state should set status to REBUILD

 

figured out the root cause of this issue:

Fix needs to be done in nova:

In nova, generally STATUS field is determined by the 'vm_state' and 'task_state'.
And presently for an instance with vm_state= ERROR, will always report status as ERROR. (since it does not take into account the present task_state of instance)

i.e in, 
nova/nova/api/openstack/common.py 

   vm_states.ERROR: {
        'default': 'ERROR',
    },
As you can see above the task_state of instance is not taken into account if vm_state is in ERROR.


FIX:
need to change it to:
   vm_states.ERROR: {
        'default': 'ERROR',
        task_states.REBUILDING: 'REBUILD',
        task_states.REBUILD_BLOCK_DEVICE_MAPPING: 'REBUILD',
        task_states.REBUILD_SPAWNING: 'REBUILD',
    },

will wait for nova guys to let me know if they are ok with this change.

** Also affects: nova
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1362733

Title:
  Rebuilding a node in ERROR state should set status to REBUILD

Status in OpenStack Bare Metal Provisioning Service (Ironic):
  Confirmed
Status in OpenStack Compute (Nova):
  New

Bug description:
  I recently had a few nova-driven ironic nodes fail to deploy, and
  resurrected them by issuing another nova rebuild.

  This worked quite nicely, but the Status stayed as ERROR, when I would
  have expected it to change back to REBUILD

To manage notifications about this bug go to:
https://bugs.launchpad.net/ironic/+bug/1362733/+subscriptions