yahoo-eng-team team mailing list archive

Thread
Date

[Bug 925456] Re: firewall: setup_basic_filtering() and prepare_instance_filter() can be merged

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Sean Dague <sean@xxxxxxxxx>
Date: Wed, 17 Sep 2014 18:25:18 -0000
Reply-to: Bug 925456 <925456@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

A current look at the nova source code is that in the libvirt tree this
isn't true. only 2 of 4 calls use both. So marking as invalid

** Changed in: nova
       Status: In Progress => Invalid

** Changed in: nova
     Assignee: Mohammed Naser (mnaser) => (unassigned)

** Changed in: nova
   Importance: Low => Wishlist

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/925456

Title:
  firewall: setup_basic_filtering() and prepare_instance_filter() can be
  merged

Status in OpenStack Compute (Nova):
  Invalid

Bug description:
  Each of the 4 places where setup_basic_filtering() is called, we
  immediately call prepare_instance_filter() right after it

  The split doesn't look useful to me, we can just merge the two calls

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/925456/+subscriptions