yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1203417] Re: Catching and ignoring Exceptions can mask Mox failures

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Sean Dague <sean@xxxxxxxxx>
Date: Thu, 18 Sep 2014 23:22:37 -0000
Reply-to: Bug 1203417 <1203417@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

been incomplete for a long time. Burt please reopen if you have examples
to fix.

** Changed in: nova
       Status: Incomplete => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1203417

Title:
  Catching and ignoring Exceptions can mask Mox failures

Status in OpenStack Compute (Nova):
  Invalid

Bug description:
  While writing a new unit test for _sync_power_state, I noticed that they should have been failing but were reported as passing.
  I should have seen errors for unexpected method calls and expected method calls that didn't happen, but they got swallowed by code which caught all exceptions, logged them, but didn't re-raise.

  expect Exception:
    LOG.exception..

  We should catch exceptions as narrowly as possible (at the very worst
  NovaException?) to avoid this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1203417/+subscriptions