← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1251261] Re: finish_revert_migration does not include context as parameter

 

** Also affects: nova/havana
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1251261

Title:
  finish_revert_migration does not include context as parameter

Status in OpenStack Compute (Nova):
  Fix Released
Status in OpenStack Compute (nova) havana series:
  New

Bug description:
  When finish_revert_migration is called, the caller of
  finish_revert_migration already includes context as a parameter,
  but finish_revert_migration did not reuse this parameter and still
  re-generate the context inside finish_revert_migration, we should
  add context as a new parameter for finish_revert_migration so that
  the functions inside of it can reuse context when needed.

  For the function _create_domain_and_network in libvirt/driver.py,
  it set context as an optional parameter, but context isn't really
  an optional parameter for this method. We should always pass a
  context down because it might be needed somewhere inside
  _create_domain_and_network().

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1251261/+subscriptions