yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1214406] Re: nova.virt.block_device.get_swap should have better safeguards

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Wed, 01 Oct 2014 07:45:11 -0000
Reply-to: Bug 1214406 <1214406@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1214406

Title:
  nova.virt.block_device.get_swap should have better safeguards

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  As per markmc's comments on https://review.openstack.org/#/c/39086/24
  - the function is used to get the swap out of the list context as the
  block_device_info data structure (used internally by the virt drivers)
  needs 'swap' field to be either a single dict or none. However if
  passed something that is not an obvious list of swap looking things -
  the function will happily reutrn the passed list.

  More safe and correct behaviour would be to return None (or raise).

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1214406/+subscriptions