yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1371559] Re: v2 image-update does not handle some schema properties properly

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: OpenStack Infra <1371559@xxxxxxxxxxxxxxxxxx>
Date: Tue, 07 Oct 2014 14:11:35 -0000
Reply-to: Bug 1371559 <1371559@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

Reviewed:  https://review.openstack.org/126479
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=0f3b518028196b5c8c36b378928dae31c2c4a6fa
Submitter: Jenkins
Branch:    proposed/juno

commit 0f3b518028196b5c8c36b378928dae31c2c4a6fa
Author: Kamil Rykowski <kamil.rykowski@xxxxxxxxx>
Date:   Wed Sep 24 14:15:59 2014 +0200

    Mark custom properties in image schema as non-base
    
    Currently it is impossible to determine if given image schema property
    is base or custom one and knowledge of that can be handy in some
    situations.    Proposed change appends to every custom property special
    key which determiness that it is not a base property.
    
    Change-Id: I49255255df311036d516768afc55475c1f9aad47
    Partial-Bug: #1371559
    (cherry picked from commit 94c05cbdbb3a78b3df4df8d522555f34d2f0a166)


** Changed in: glance
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1371559

Title:
  v2 image-update does not handle some schema properties properly

Status in OpenStack Image Registry and Delivery Service (Glance):
  Fix Released
Status in Python client library for Glance:
  Fix Committed

Bug description:
  Step1: Create an empty image using api v1 or v2.
  Step2:  Use glanceclient with v2 API to update image property called "architecture":

  glance --os-image-api-version 2 image-update --property
  architecture='x86'

  This will show following error message:

  <html>
    <head>
      <title>409 Conflict</title>
    </head>
    <body>
      <h1>409 Conflict</h1>
      There was a conflict when trying to complete your request.<br /><br />
      Property architecture does not exist.

    </body>
  </html> (HTTP 409)

  The error shows up, because the client sends to glance API following
  data:

  [{"patch: "/architecture", "value": "x86", "op": "replace"}]

  instead of

  [{"patch: "/architecture", "value": "x86", "op": "add"}]

  The issue is somehow related to overridden patch method in
  SchemaBasedModel class, which propagates non existing properties from
  schema properties.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1371559/+subscriptions