← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1376102] Re: Unnecesary to catch FloatingIpAssociated on addFloatingIp REST API

 

Marking this as won't fix, ok Ken? (since
https://review.openstack.org/#/c/125267 is abandoned)

** Changed in: nova
       Status: In Progress => Won't Fix

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1376102

Title:
  Unnecesary to catch FloatingIpAssociated on addFloatingIp REST API

Status in OpenStack Compute (Nova):
  Won't Fix

Bug description:
  FloatingIpAssociated exception happens on the following cases only:

  * nova/network/neutronv2/api.py: disassociate_floating_ip
  * nova/network/floating_ips.py: deallocate_floating_ip

  However, addFloatingIp REST API catches the exception now.

  Maybe this catch had been added for associating the associated
  floating-ip, but now the association against the associated floating-
  ip succeeds like the following:

  $ nova list
  +--------------------------------------+------+--------+------------+-------------+------------------------------+
  | ID                                   | Name | Status | Task State | Power State | Networks                     |
  +--------------------------------------+------+--------+------------+-------------+------------------------------+
  | 1c73fc7d-5918-43b1-94f4-4898adf47884 | vm01 | ACTIVE | -          | Running     | private=10.0.0.2             |
  | 7fd66909-eab1-4408-b831-2ef1210ac196 | vm02 | ACTIVE | -          | Running     | private=10.0.0.3, 172.24.4.1 |
  +--------------------------------------+------+--------+------------+-------------+------------------------------+
  $ nova floating-ip-associate vm01 172.24.4.1
  $ nova list
  +--------------------------------------+------+--------+------------+-------------+------------------------------+
  | ID                                   | Name | Status | Task State | Power State | Networks                     |
  +--------------------------------------+------+--------+------------+-------------+------------------------------+
  | 1c73fc7d-5918-43b1-94f4-4898adf47884 | vm01 | ACTIVE | -          | Running     | private=10.0.0.2, 172.24.4.1 |
  | 7fd66909-eab1-4408-b831-2ef1210ac196 | vm02 | ACTIVE | -          | Running     | private=10.0.0.3             |
  +--------------------------------------+------+--------+------------+-------------+------------------------------+

  So now this catch seems unnecessary.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1376102/+subscriptions


References