yahoo-eng-team team mailing list archive

[Steve Martinelli <stevemar@xxxxxxxxxx>]

test_backend.py does as it suggests, it creates an instance of
catalog_api or whatever is comparable (identity_api), and it attempts to
test functions that are common to all backends.

test_catalog.py should be testing a larger flow, it'll hit the endpoint
(tests the routers.py file), and the controller (tests the controller.py
file), and finally the backend. So I think there is merit to having both
exist.


Also, we generally don't file bugs for tests (unless they are failing), more so for refactoring. 

If you disagree re-open the bug,

** Changed in: keystone
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1396650

Title:
  Duplicated tests for Catalog

Status in OpenStack Identity (Keystone):
  Invalid

Bug description:
  About testing the catalog backends (KVS, SQL and Templated). Now, we
  have to different test files to do the same things.

  keystone/tests/test_backend.py -> Which has a lot of test related with Identity, Policy, Token, ... and Catalog
  keystone/tests/test_catalog.py   -> Which has a few tests only for the catalog backends. Those test are not enough to test everything in the catalog.

  In my opinion is not a good idea to have different test files for the
  same purpose because some people could implement test only in one of
  the test files, not in both. Also, it is a pain to maintain.

  I propose to remove all the test that we have right now in
  keystone/tests/test_catalog.py (please forget class
  V2CatalogTestCase(rest.RestfulTestCase)) and move the tests related
  with Catalog that, right now, we have in
  keystone/tests/test_backend.py to keystone/tests/test_catalog.py

  What do you think?

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1396650/+subscriptions