yahoo-eng-team team mailing list archive

[Marcos Lobo <1396650@xxxxxxxxxxxxxxxxxx>]

Ok Steve, I understand the goal of each test file.

My point is, now we have 3 different catalog backends. test_catalog.py
is not be able to manage the different implementations from those
backends.

For example, in this patch https://review.openstack.org/#/c/120011/ I'm
implementing methods for Templated backed. Some of the functionality
makes no sense for Templated Catalog but it does in SQL Catalog (create
regions, for example). So, in the (let's say) "special" case of "create
regions using Templated Catalog" I'm raising NotImplemented exception.
For this exception, test_catalog.py tests are not be able to manage it,
because those tests think that the behavior should be the same from
different backends.

Maybe, the workaround, could be try to improve test_catalog.py tests...

I really appreciate your feedback.

** Changed in: keystone
       Status: Invalid => New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1396650

Title:
  Duplicated tests for Catalog

Status in OpenStack Identity (Keystone):
  New

Bug description:
  About testing the catalog backends (KVS, SQL and Templated). Now, we
  have to different test files to do the same things.

  keystone/tests/test_backend.py -> Which has a lot of test related with Identity, Policy, Token, ... and Catalog
  keystone/tests/test_catalog.py   -> Which has a few tests only for the catalog backends. Those test are not enough to test everything in the catalog.

  In my opinion is not a good idea to have different test files for the
  same purpose because some people could implement test only in one of
  the test files, not in both. Also, it is a pain to maintain.

  I propose to remove all the test that we have right now in
  keystone/tests/test_catalog.py (please forget class
  V2CatalogTestCase(rest.RestfulTestCase)) and move the tests related
  with Catalog that, right now, we have in
  keystone/tests/test_backend.py to keystone/tests/test_catalog.py

  What do you think?

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1396650/+subscriptions