← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1261598] Re: VPNaaS doesn't consider subnet interface or router gateway removal operation after vpnservice is created

 

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1261598

Title:
  VPNaaS doesn't consider subnet interface or router gateway removal
  operation after vpnservice is created

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  Bug #1258379 is fixed by adding router gateway check when creating
  vpnservice. But it does not consider subnet interface or router
  gateway remove operation when creating or updating ipsec site
  connection and updating vpnservice operation.

  For example, 1. Create router 2.add router gateway and subnet interface 3. create vpnservice 4. clear router gateway 5. create ipsec site connection would lead to these following internal server error:
  2014-01-29 13:16:27.926 ERROR neutron.openstack.common.rpc.amqp [reqe9fb3a0ac61b-489e-8f09-0b2d6a7f35e4 None None] Exception during message handling
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp Traceback (most recent call last):
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp   File "/opt/stack/neutron/neutron/openstack/common/rpc/amqp.py", line 462, in _process_data
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp     **args)
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp   File "/opt/stack/neutron/neutron/common/rpc.py", line 45, in dispatch
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp     neutron_ctxt, version, method, namespace, **kwargs)
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp   File "/opt/stack/neutron/neutron/openstack/common/rpc/dispatcher.py", line 172, in dispatch
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp     result = getattr(proxyobj, method)(ctxt, **kwargs)
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp   File "/opt/stack/neutron/neutron/services/vpn/service_drivers/ipsec.py", line 55, in get_vpn_services_on_host
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp     for vpnservice in vpnservices]
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp   File "/opt/stack/neutron/neutron/services/vpn/service_drivers/ipsec.py", line 173, in _make_vpnservice_dict
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp     'fixed_ips'][0]['ip_address']
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp TypeError: 'NoneType' object has no attribute '__getitem__'
  2014-01-29 13:16:27.926 TRACE neutron.openstack.common.rpc.amqp
  2014-01-29 13:16:27.975 ERROR neutron.openstack.common.rpc.common [req-e9fb3a0a-c61b-489e-8f09-0b2d6a7f35e4 None None] Returning exception 'NoneType' object has no attribute '__getitem__' to caller
  2014-01-29 13:16:27.975 ERROR neutron.openstack.common.rpc.common [req-e9fb3a0a-c61b-489e-8f09-0b2d6a7f35e4 None None] ['Traceback (most recent call last):\n', '  File "/opt/stack/neutron/neutron/openstack/common/rpc/amqp.py", line 462, in _process_data\n    **args)\n', '  File "/opt/stack/neutron/neutron/common/rpc.py", line 45, in dispatch\n    neutron_ctxt, version, method, namespace, **kwargs)\n', '  File "/opt/stack/neutron/neutron/openstack/common/rpc/dispatcher.py", line 172, in dispatch\n    result = getattr(proxyobj, method)(ctxt, **kwargs)\n', '  File "/opt/stack/neutron/neutron/services/vpn/service_drivers/ipsec.py", line 55, in get_vpn_services_on_host\n    for vpnservice in vpnservices]\n', '  File "/opt/stack/neutron/neutron/services/vpn/service_drivers/ipsec.py", line 173, in _make_vpnservice_dict\n    \'fixed_ips\'][0][\'ip_address\']\n', "TypeError: 'NoneType' object has no attribute '__getitem__'\n"]

  Also, After removing the subnet interface, there is not any warning or
  error info existed in server or vpn agent when creating an ipsec site
  connection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1261598/+subscriptions


References