← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1188226] Re: Confusing behavior of default `image_cache_manager_interval` and `instance_delete_interval`

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => kilo-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1188226

Title:
  Confusing behavior of default `image_cache_manager_interval` and
  `instance_delete_interval`

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  In all periodic tasks, an "interval" setting of 0 means that the task is executed at every run of the scheduler.
  Well, all except `image_cache_manager_interval`, where a setting of 0 means "disabled"!

  Excerpt from Folsom's `nova/compute/manager.py` (lines 2926--2932):

      @manager.periodic_task(
          ticks_between_runs=FLAGS.image_cache_manager_interval)
      def _run_image_cache_manager_pass(self, context):
          """Run a single pass of the image cache manager."""

          if FLAGS.image_cache_manager_interval == 0:
              return
          # ...

  What is even more confusing is that the periodic command scheduler
  will log "Running periodic task
  ComputeManager._run_image_cache_manager_pass" *before* entering the
  `_run_image_cache_manager_pass` method, so, according to the logs, the
  task is executing normally...

  Please make `image_cache_manager_interval` behave like the other
  intervals, or -at least- log a line to the extent that the task is
  disabled.

  
  Running Folsom's python-nova on Ubuntu 12.04:
   
  # dpkg -l python-nova
  Desired=Unknown/Install/Remove/Purge/Hold
  | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
  |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
  ||/ Name                              Version                           Description
  +++-=================================-=================================-==================================================================================
  ii  python-nova                       2012.2.1+stable-20121212-a99a802e OpenStack Compute Python libraries

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1188226/+subscriptions