← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1392663] Re: Un-used function check_attach() in module nova.volume.cinder

 

I've checked this issue again.
With the latest master code, this function is really in use as follows:

nova/virt/block_device.py:226:            volume_api.check_attach(context, volume, instance=instance)
nova/compute/api.py:1022:                # and depends on followed volume_api.check_attach() to
nova/compute/api.py:1244:                    self.volume_api.check_attach(context,
nova/compute/api.py:2989:            self.volume_api.check_attach(context, volume, instance=instance)
nova/compute/api.py:3064:        self.volume_api.check_attach(context, new_volume, instance=instance)
nova/compute/cells_api.py:424:        self.volume_api.check_attach(context, volume, instance=instance)

So, please remove this bug report!

** Changed in: nova
       Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1392663

Title:
  Un-used function check_attach() in module nova.volume.cinder

Status in OpenStack Compute (Nova):
  Invalid

Bug description:
  Version: stable/juno

  The function check_attach() in module nova.volume.cinder is really un-used. It's only used in Unit-Test.
  In fact, if this function is really used in reality, then it will be impossible to attach a volume to a VM instance in the case that the volume is created in a different availability_zone than the VM instance.

  However,  in reality, for single-node deployment, if a new
  availability_zone is created in Nova and thus the default
  availability_zone of Nova is replaced, then Nova compute service will
  be running in this newly-created availability_zone while Cinder
  services are still running in the default availability_zone. It is
  quite possible to attach a volume (created in the default
  availability_zone) to a VM instance (created in the new
  availability_zone)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1392663/+subscriptions


References