yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: neutron
       Status: Fix Committed => Fix Released

** Changed in: neutron
    Milestone: None => kilo-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1370342

Title:
  AttributeError: object has no attribute 'update_security_group_rules'

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  With recent merged code support If19be8579ca734a899cdd673c919eee8165aaa0e (Refactor security group rpc call)
  Introduce two methods for firewall driver used by the securitygroup_rpc.py

  update_security_group_rules
  update_security_group_members

  def _update_security_group_info(self, security_groups,
                                      security_group_member_ips):
          LOG.debug("Update security group information")
          for sg_id, sg_rules in security_groups.items():
              self.firewall.update_security_group_rules(sg_id, sg_rules)
          for remote_sg_id, member_ips in security_group_member_ips.items():
              self.firewall.update_security_group_members(
                  remote_sg_id, member_ips)

  Since these two methods are added in iptables_firewall.py. This will
  cause other firewall driver to fail when neutron agent startup.  Such
  as  HyperV agent and HyperVSecurityGroupsDriver.

  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Traceback (most recent call last):
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/usr/lib/python2.6/site-packages/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py", line 1402, in rpc_loop
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     ovs_restarted)
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/usr/lib/python2.6/site-packages/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py", line 1201, in process_network_ports
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     port_info.get('updated', set()))
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/usr/lib/python2.6/site-packages/neutron/agent/securitygroups_rpc.py", line 316, in setup_port_filters
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     self.prepare_devices_filter(new_devices)
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/usr/lib/python2.6/site-packages/neutron/agent/securitygroups_rpc.py", line 211, in prepare_devices_filter
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     security_groups, security_group_member_ips)
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/usr/lib64/python2.6/contextlib.py", line 34, in __exit__
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     self.gen.throw(type, value, traceback)
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/usr/lib/python2.6/site-packages/neutron/agent/firewall.py", line 104, in defer_apply
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     yield
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/usr/lib/python2.6/site-packages/neutron/agent/securitygroups_rpc.py", line 211, in prepare_devices_filter
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     security_groups, security_group_member_ips)
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/usr/lib/python2.6/site-packages/neutron/agent/securitygroups_rpc.py", line 217, in _update_security_group_info
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     self.firewall.update_security_group_rules(sg_id, sg_rules)
  2014-09-17 12:02:50.620 1789 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent AttributeError: 'NoopFirewallDriver' object has no attribute 'update_security_group_rules'

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1370342/+subscriptions