yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1296722

Title:
  Error message misleading when unable to create new image due to glance
  file filtering

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Description of problem:
  When filtering supported file types in Glance, uploading a none supported file gives a none informative/misleading error on Horizon -> Error: Unable to create new image. 

  Uploading same image in Glance CLI returns a better warning: Invalid
  disk format

  [root@cougar12 ~(keystone_admin)]# glance  image-create --name isoShouldFail1 --disk-format iso --container-format bare --file /dsl-4.4.10.iso
  Request returned failure status.
  400 Bad Request
  Invalid disk format 'iso' for image.
      (HTTP 400)

  
  Version-Release number of selected component (if applicable):
   RHEL 6.5
   python-django-openstack-auth-1.1.2-2.el6ost.noarch
   openstack-glance-2013.2.2-2.el6ost.noarch

  
  How reproducible:
  Every time

  
  Steps to Reproduce:
  1. Setup deployment
  2. on /etc/glance/glance-api.conf, enable disk_formats and remove one of them (I removed iso),   disk_formats=ami,ari,aki,vhd,vmdk,raw,qcow2,vdi
  3. Restart glance-api service
  4. From Horizon upload a new image from file, select a file of the format you deleted from list on step 2. 
  5. Get Horizon error

  Actual results:
  On Horizon none informative error message: Error: Unable to create new image.

  Expected results:
  I'd expect a better error like: Unable to create new image, none supported "iso" format. Seeing as this info is found on Horizon.log why isn't it returned on error message.

  
  Description of problem:
  When filtering supported file types in Glance, uploading a none supported file gives a none informative/misleading error on Horizon -> Error: Unable to create new image. 

  Uploading same image in Glance CLI returns a better warning: Invalid
  disk format

  [root@cougar12 ~(keystone_admin)]# glance  image-create --name isoShouldFail1 --disk-format iso --container-format bare --file /dsl-4.4.10.iso
  Request returned failure status.
  400 Bad Request
  Invalid disk format 'iso' for image.
      (HTTP 400)

  
  Version-Release number of selected component (if applicable):
  RHEL 6.5
  python-django-openstack-auth-1.1.2-2.el6ost.noarch
  openstack-glance-2013.2.2-2.el6ost.noarch

  
  How reproducible:
  Every time

  
  Steps to Reproduce:
  1. Setup deployment
  2. on /etc/glance/glance-api.conf, enable disk_formats and remove one of them (on test removed iso)  disk_formats=ami,ari,aki,vhd,vmdk,raw,qcow2,vdi
  3. Restart glance-api service
  4. From Horizon upload a new image from file, select a file of the format you deleted from list on step 2. 
  5. Get Horizon none informative error.

  Actual results:
  On Horizon none informative error message: Error: Unable to create new image.

  Expected results:
  I'd expect a better error like, Unable to create new image, none supported "iso" format. Seeing as this info is found on Horizon.log(see below) why isn't this important info featured on Horizon's error message.

  Horizon.log

  date: Mon, 24 Mar 2014 13:00:56 GMT
  content-length: 58
  content-type: text/plain; charset=UTF-8
  x-openstack-request-id: req-45e2c4b5-abb7-48a3-8725-132e34c06de0

  400 Bad Request
  Invalid disk format 'iso' for image.
   
  2014-03-24 13:00:57,119 4603 ERROR glanceclient.common.http Request returned failure status.
  2014-03-24 13:00:57,119 4603 WARNING horizon.exceptions Recoverable error: 400 Bad Request
  Invalid disk format 'iso' for image.
      (HTTP 400)
  2014-03-24 13:00:57,152 4603 DEBUG horizon.base Panel with slug "domains" is not registered with Dashboard "admin".
  2014-03-24 13:00:57,152 4603 DEBUG horizon.base Panel with slug "groups" is not registered with Dashboard "admin".

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1296722/+subscriptions