yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

** Changed in: horizon
    Milestone: None => kilo-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1403701

Title:
  Panel visibility check for Aggregates is overriding the wrong method

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  There are two patterns used in defined if panels are visible:
  1. overriding allowed()

  https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/firewalls/panel.py#L26

  2. overriding can_access()

  https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/aggregates/panel.py#L26

  One of this is wrong and must be consistent with the other.

  According to the doc, can_access() is not supposed to overridden:
  https://github.com/openstack/horizon/blob/master/horizon/base.py#L114

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1403701/+subscriptions