← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1404196] Re: many codepaths do not pass image_meta to libvirt blockinfo APIs

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => kilo-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1404196

Title:
  many codepaths do not pass image_meta to libvirt blockinfo APIs

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  This bug reported a problem with the finish_migration method not
  passing image_meta to the libvirt blockinfo APIs

  https://bugs.launchpad.net/nova/+bug/1389850

  On closer inspection there are a great many codepaths which don't pass
  image_meta to the libvirt blockinfo APIs. Essentially every single one
  of these is a bug which needs fixing, otherwise the user requested
  disk bus will not be honoured in those scenarios.

  The best fix is to stop making the image_meta parameter be optional,
  with a None default. Make it compulsory and do not provide a default
  value. This way all callers are forced to pass it, which should reduce
  the scale of the problem

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1404196/+subscriptions


References