yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #28743
[Bug 1424825] Re: Parsing of service catalog should be less error prone
jamielennox: good call, didn't noticed that auth plugins also exposed
the get_endpoint() method too. We should move to that instead.
** Also affects: horizon
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1424825
Title:
Parsing of service catalog should be less error prone
Status in Django OpenStack Auth:
New
Status in OpenStack Dashboard (Horizon):
New
Bug description:
Currently, parsing of the service catalog is hard-coded and dependent
on the data structure of the service catalog.
For example:
in user.py
@property
def available_services_regions(self):
"""Returns list of unique region name values in service catalog."""
regions = []
if self.service_catalog:
for service in self.service_catalog:
if service['type'] == 'identity':
continue
for endpoint in service['endpoints']:
if endpoint['region'] not in regions:
regions.append(endpoint['region'])
return regions
This code is prone to issue if the structure of the service catalog
changes, it should be using the public interfaces of Service Catalog
object from KSC when parsing rather than directly accessing the
service_catalog dictionary.
To manage notifications about this bug go to:
https://bugs.launchpad.net/django-openstack-auth/+bug/1424825/+subscriptions