yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: keystone
       Status: Fix Committed => Fix Released

** Changed in: keystone
    Milestone: None => kilo-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1396083

Title:
  Improve List Role Assignments Tests

Status in OpenStack Identity (Keystone):
  Fix Released

Bug description:
  When listing role assignments, it is possible to filter results by group, role, domain, project, user and inheritance.
  In addition, it is possible to query for effective role assignments, which expands inherited roles and group membership.

  Currently we have few tests [1][2][3][4] that try to cover as many cases as possible inside their bodies.
  The result is that we have big methods containing up to 174 loc [4].

  Besides ensuring that we are covering all available filters plus
  effective mode, we need to make those tests smaller, easing the
  readability and maintainability.

  [1] https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_assignment.py#L822
  [2] https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_assignment.py#L925
  [3] https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_assignment.py#L990
  [4] https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_assignment.py#L1082-L1255

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1396083/+subscriptions