yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1422905

Title:
  VPNaaS refactor service driver to reuse VpnDriver code

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  Currently various VPN service-drivers in neutron-vpnaas repo doesn't
  reuse code  which is same for most part. Topic connection creation and
  make_vpnservice_dict (again optional) are different for each service-
  driver. This came up during the code review of [1].

  The proposal is to refactor this code to have a base class with a
  separate "create_rpc_connection" method which will be overridden by
  different service-driver implementations.

  [1]
  https://review.openstack.org/#/c/154720/5/neutron_vpnaas/services/vpn/service_drivers/vyatta_ipsec.py,unified

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1422905/+subscriptions