yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

** Changed in: horizon
    Milestone: None => kilo-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1353194

Title:
  error handling patterns are not consistent in volumes forms

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  There are a couple of patterns of form's exception handling in
  volumes. Each of them behaves differently.

  for example:

  1. in admin volumes create volume type

          except Exception:
              exceptions.handle(request,
                                _('Unable to create volume type.'))
              return False

  When error happens, the dialog stays open, error message shows up at
  the upper right corner of the browser.

  2.       in project volumes
     except Exception:
              exceptions.handle(request, ignore=True)
              self.api_error(_("Unable to create volume."))
              return False

  When error happens, the dialog stays open, error message within the
  form at he upper left corner in red.

  3.  in project volumes.
  except Exception:
              redirect = reverse("horizon:project:volumes:index")
              exceptions.handle(request,
                                _('Unable to attach volume.'),
                                redirect=redirect)

  when error happens , the dialog closes, error message shows up at the
  upper right corner of the browser.

  Would like to have consistent behaviors for users.  This is a
  wishlist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1353194/+subscriptions