yahoo-eng-team team mailing list archive

[Sean Dague <sean@xxxxxxxxx>]

Looks fixed in code:

libvirt/driver.py

    def rescue(self, context, instance, network_info, image_meta,
               rescue_password):
        """Loads a VM using rescue images.

        A rescue is normally performed when something goes wrong with the
        primary images and data needs to be corrected/recovered. Rescuing
        should not edit or over-ride the original image, only allow for
        data recovery.

        """
        instance_dir = libvirt_utils.get_instance_path(instance)
        unrescue_xml = self._get_existing_domain_xml(instance, network_info)
        unrescue_xml_path = os.path.join(instance_dir, 'unrescue.xml')
        libvirt_utils.write_to_file(unrescue_xml_path, unrescue_xml)

        if image_meta is not None:
            rescue_image_id = image_meta.get('id')
        else:
            rescue_image_id = None

** Changed in: nova
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1078080

Title:
  libvirt rescue doesn't respect image_meta passed in

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  The libvirt driver currently ignores the `image_meta` field passed in
  on the rescue method and instead uses it's driver-specific
  'rescue_image_id` flag or the instance's current image.

  We should probably two things here to make this code more similar
  across hypervisors:

  1. We should add a generic `default_rescue_image_id` flag that can
  specific default rescue images for any driver. This would obsolete the
  libvirt specific flag.

  2. We should modify the libvirt `rescue` code to respect the
  `image_meta` passed in, delegating the logic of which image to use for
  rescue to the compute manager.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1078080/+subscriptions