yahoo-eng-team team mailing list archive

[Doug Hellmann <doug@xxxxxxxxxxxxxxxx>]

** Changed in: glance
       Status: Fix Committed => Fix Released

** Changed in: glance
    Milestone: None => liberty-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1422699

Title:
  glance api doesn't abort start up on Store configuration errors

Status in OpenStack Image Registry and Delivery Service (Glance):
  Fix Released
Status in OpenStack Glance backend store-drivers library (glance_store):
  Fix Released

Bug description:
  Glance api service does not abort start up when errors in glance-api.cfg file are encountered.
  It would make sense to abort service start up when a BadStoreConfiguration exception is encountered, instead of just sending the error to the logs and disabling adding images to that Store.

  For example if a Filesystem Storage Backend with multiple store is configured with a duplicate directory:
  filesystem_store_datadirs=/mnt/nfs1/images/:200
  filesystem_store_datadirs=/mnt/nfs1/images/:100

  Logs will have the error:
  ERROR glance_store._drivers.filesystem [-] Directory /mnt/nfs1/image specified multiple times in filesystem_store_datadirs option of filesystem configuration
  TRACE glance_store._drivers.filesystem None
  TRACE glance_store._drivers.filesystem
  WARNING glance_store.driver [-] Failed to configure store correctly: None Disabling add method.

  Service will start and when client tries to add an image he will
  receive a 410 Gone error saying: Error in store configuration. Adding
  images to store is disabled.

  This affects not only the filesystem storage backend but all glance-
  storage drivers that encounter an error in the configuration and raise
  a BadStoreConfiguration exception.

  How reproducible:
  Every time

  Steps to Reproduce:
  1. Configure Glance to use  Filesystem Storage Backend with multiple store and duplicate a filesystem_storage_datadirs.
  2. Run glance api

  Expected behavior:
  Glance api service should not have started and should have reported that the directory was specified multiple times.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1422699/+subscriptions