← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1446834] Re: Project tree cycle checking logic is broken

 

** Changed in: keystone
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1446834

Title:
  Project tree cycle checking logic is broken

Status in OpenStack Identity (Keystone):
  Fix Released

Bug description:
  The keystone.resource.backends.sql.Resource.list_projects_in_subtree
  method tries to check for cycles in the project hierarchy [1]. It's
  doing it wrong. This was not caught because there are no tests for it
  because you can't actually create cycles through the API.

  There are two things we can do here:

  1. Be satisfied that we don't allow cycles and remove the checks
  2. Fix then and mock out the tests to fabricate cycles

  [1]
  https://github.com/openstack/keystone/blob/master/keystone/resource/backends/sql.py#L97

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1446834/+subscriptions


References