← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1427056] Re: shelved_image_id is deleted before completing unshelving instance on compute node

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => liberty-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1427056

Title:
  shelved_image_id is deleted before completing unshelving instance on
  compute node

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  Steps to reproduce:

  1. Boot an instance from image.
  2. Call Shelve instance, instance becomes SHELVED_OFFLOADED or SHELVED state depending on 'shelved_offload_time' configured in nova.conf.
  3. Call unshelve instance.

     For shelved_offload_time >= 0:
     3.1 nova-conductor calls RPC.Cast to nova-compute
     If some failure happens in nova-compute. e.g. "Instance failed to spawn" error      from libvirt
     3.2 nova-conductor deletes instance_system_metadata.shelved_image_id after RPC.cast for unshelving the instance.
     3.3 Instance becomes SHELVED_OFFLOADED again by revert_task_state, but instance_system_metadata.shelved_image_id is already deleted for this instance

  For shelved_offload_time = -1:
     3.1 nova-conductor calls RPC.Cast to nova-compute
     If some failure happens in nova-compute. e.g. "InstanceNotFound" error while starting the instance.
     3.2 nova-conductor deletes snapshot and instance_system_metadata.shelved_image_id after RPC.cast to start the instance.
     3.3 Instance becomes SHELVED again by revert_task_state, but snapshot and  instance_system_metadata.shelved_image_id is already deleted for this instance

  Problems:
  1. As there is no shelved_image_id, during unshelving the instance again, it gives error while getting image-meta in
     libvirt driver and instance remains in SHELVED_OFFLOADED state.

  2. As there is no shelved_image_id, deleting the instance will try to
  delete "image_id=None" image from glance, but 404 error will be
  returned from glance, instance will be successfully deleted, and
  shelved image remains.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1427056/+subscriptions


References