yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #35118
[Bug 1467780] Re: Unused config_files parameter of service entry
** Changed in: keystone
Importance: Undecided => Wishlist
** Changed in: keystone
Status: In Progress => Opinion
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1467780
Title:
Unused config_files parameter of service entry
Status in OpenStack Identity (Keystone):
Opinion
Bug description:
The entry of keystone service tried to provide a default config file
path to load config options, but the path is unused. Actually, the
oslo_config lib can automatically find default config file or
automatically load the config file specified by --config-file option.
So the useless code should be removed.
The following is debug trace when using'keystone-manage' command with
breakpoint, the other keystone service scripts is similar. it obvious
that the 'config_file' parameter inputted to cli.main is None. The
path of config file is impossible be "/usr/etc/keystone.conf".
> /opt/stack/keystone/keystone/cmd/manage.py(44)main()
-> config_files = None
(Pdb) l
39 environment.use_stdlib()
40
41 dev_conf = os.path.join(possible_topdir,
42 'etc',
43 'keystone.conf')
44 -> config_files = None
45 if os.path.exists(dev_conf):
46 config_files = [dev_conf]
47
48 cli.main(argv=sys.argv, config_files=config_files)
[EOF]
(Pdb) p sys.argv[0]
'/usr/local/bin/keystone-manage'
(Pdb) p possible_topdir
'/usr'
(Pdb) p dev_conf
'/usr/etc/keystone.conf'
To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1467780/+subscriptions
References