yahoo-eng-team team mailing list archive

[Thai Tran <tqtran@xxxxxxxxxx>]

Public bug reported:

Currently, the simple modal service is named "modal.service.js". This is
incorrect, the file name should be "simple-modal.service.js" or
something similar. Why do we care about a rename? We will likely
introduce other modal services in the near future (i.e. wizard-
modal.service). Leaving it as is leaves room for naming collision.

Link to the modal module:
https://github.com/openstack/horizon/tree/1791ae066e1f769f385648282793407cc7749702/horizon/static/framework/widgets/modal

** Affects: horizon
     Importance: Medium
         Status: New


** Tags: low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1475046

Title:
  Modal service is incorrectly named

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Currently, the simple modal service is named "modal.service.js". This
  is incorrect, the file name should be "simple-modal.service.js" or
  something similar. Why do we care about a rename? We will likely
  introduce other modal services in the near future (i.e. wizard-
  modal.service). Leaving it as is leaves room for naming collision.

  Link to the modal module:
  https://github.com/openstack/horizon/tree/1791ae066e1f769f385648282793407cc7749702/horizon/static/framework/widgets/modal

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1475046/+subscriptions