yahoo-eng-team team mailing list archive

[Doug Fish <drfish@xxxxxxxxxx>]

Public bug reported:

While reviewing translation code at the mid-cycle we discussed that
there is a troublesome set of code that is converting javascript/angular
style interpolation to python style interpolation and back.

I don't think we need to do that. Have a look at the existing files:
https://github.com/openstack/horizon/blob/master/openstack_dashboard/locale/django.pot#L3420
msgid "Namespace Details: {{ namespace.namespace }}"

https://github.com/openstack/horizon/blob/master/openstack_dashboard/locale/djangojs.pot#L285
"The selected image source requires a flavor with at least %(minDisk)s GB "

we already use different style interpolation strings in our pot files. I don't think that's going to be a problem. Let's remove the code that does that conversion and avoid the complexity. I'm thinking of code such as:
https://github.com/openstack/horizon/blob/17342c2d42a508090fa7a77c1bf291a3829531aa/horizon/utils/babel_extract_angular.py#L58

maybe there is more?

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1476771

Title:
  No need to convert angular based messages to use python based
  interpolation

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  While reviewing translation code at the mid-cycle we discussed that
  there is a troublesome set of code that is converting
  javascript/angular style interpolation to python style interpolation
  and back.

  I don't think we need to do that. Have a look at the existing files:
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/locale/django.pot#L3420
  msgid "Namespace Details: {{ namespace.namespace }}"

  https://github.com/openstack/horizon/blob/master/openstack_dashboard/locale/djangojs.pot#L285
  "The selected image source requires a flavor with at least %(minDisk)s GB "

  we already use different style interpolation strings in our pot files. I don't think that's going to be a problem. Let's remove the code that does that conversion and avoid the complexity. I'm thinking of code such as:
  https://github.com/openstack/horizon/blob/17342c2d42a508090fa7a77c1bf291a3829531aa/horizon/utils/babel_extract_angular.py#L58

  maybe there is more?

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1476771/+subscriptions