yahoo-eng-team team mailing list archive

[liuyan <lykobe@xxxxxxx>]

Public bug reported:

In glance source, there is redundant comma in front of parenthesis. 
For example in below:

def _get_sort_key(self, req):
        """Parse a sort key query param from the request object."""
        sort_key = req.params.get('sort_key', 'created_at')
        if sort_key is not None and sort_key not in SUPPORTED_SORT_KEYS:
            _keys = ', '.join(SUPPORTED_SORT_KEYS)
            msg = _("Unsupported sort_key. Acceptable values: %s") % (_keys,)
            raise exc.HTTPBadRequest(explanation=msg)
        return sort_key

in line six, the commas behind "_keys" is redundant, so we should remove
it .

** Affects: glance
     Importance: Undecided
     Assignee: liuyan (lykobe)
         Status: New

** Changed in: glance
     Assignee: (unassigned) => liuyan (lykobe)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1477142

Title:
  Remove redundant commas

Status in Glance:
  New

Bug description:
  In glance source, there is redundant comma in front of parenthesis. 
  For example in below:

  def _get_sort_key(self, req):
          """Parse a sort key query param from the request object."""
          sort_key = req.params.get('sort_key', 'created_at')
          if sort_key is not None and sort_key not in SUPPORTED_SORT_KEYS:
              _keys = ', '.join(SUPPORTED_SORT_KEYS)
              msg = _("Unsupported sort_key. Acceptable values: %s") % (_keys,)
              raise exc.HTTPBadRequest(explanation=msg)
          return sort_key

  in line six, the commas behind "_keys" is redundant, so we should
  remove it .

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1477142/+subscriptions