yahoo-eng-team team mailing list archive

[Alexey Miroshkin <alexey.miroshkin@xxxxxxxxxx>]

Public bug reported:

VersionTestCase uses the same port for admin and public endpoints:

 port = random.randint(10000, 30000)
 self.config_fixture.config(group='eventlet_server', public_port=port,
                                   admin_port=port)

https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_versions.py#L648

It makes public and admin endpoints indistinguishable. As results bugs
like "Keystone API GET 5000/v3 returns wrong endpoint URL in response
body" https://bugs.launchpad.net/keystone/+bug/1381961 can't be catched
by our tests  (e.g. VersionTestCase.test_admin_version_v3)

In reality admin and public endpoints must be different:

 admin_port = random.randint(10000, 30000)
 public_port = random.randint(10000, 30000)
 self.config_fixture.config(group='eventlet_server', public_port=public_port,
                                   admin_port=admin_port)

After that VersionTestCase.test_admin_version_v3 will fail because of
bug #1381961

** Affects: keystone
     Importance: Undecided
     Assignee: Alexey Miroshkin (amirosh)
         Status: New

** Changed in: keystone
     Assignee: (unassigned) => Alexey Miroshkin (amirosh)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1478000

Title:
  VersionTestCase uses the same port for admin and public endpoints

Status in Keystone:
  New

Bug description:
  VersionTestCase uses the same port for admin and public endpoints:

   port = random.randint(10000, 30000)
   self.config_fixture.config(group='eventlet_server', public_port=port,
                                     admin_port=port)

  https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_versions.py#L648

  It makes public and admin endpoints indistinguishable. As results bugs
  like "Keystone API GET 5000/v3 returns wrong endpoint URL in response
  body" https://bugs.launchpad.net/keystone/+bug/1381961 can't be
  catched by our tests  (e.g. VersionTestCase.test_admin_version_v3)

  In reality admin and public endpoints must be different:

   admin_port = random.randint(10000, 30000)
   public_port = random.randint(10000, 30000)
   self.config_fixture.config(group='eventlet_server', public_port=public_port,
                                     admin_port=admin_port)

  After that VersionTestCase.test_admin_version_v3 will fail because of
  bug #1381961

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1478000/+subscriptions