yahoo-eng-team team mailing list archive

[Markus Zoeller <mzoeller@xxxxxxxxxx>]

@huangpengtaohw:

Thanks for this bug report. Naming variables in a readable and 
understandable way is important and improves a lot the maintainability
of the code. The change you suggested is a refactoring and doesn't need
a bug report in my opinion. I'll close this bug report as "Invalid" 
because it is not needed anymore. Just push the change you want to see 
to Gerrit and make sure you explain in the commit message that this is a
refactoring.

** Changed in: nova
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1478855

Title:
  all_mappings

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  below the function:
  nova/compute/api.py 
  def _validate_bdm(self, context, instance, instance_type, all_mappings):

  the value transfer to 'all_mappings' is 'block_device_mapping', so
  change 'all_mappings' to 'block_device_mapping' will be easier to
  understand

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1478855/+subscriptions